Add ESLint to winamp-eqf and include in CI - #1322
Merged
Merged
Conversation
- Add lint script to winamp-eqf package.json - Add winamp-eqf#lint task to turbo.json so it runs in CI
✅ Deploy Preview for tourmaline-kringle-c98715 canceled.
|
|
Size Change: 0 B 🆕 Total Size: 0 B |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
winamp-eqfpackage had no lint script and wasn't being linted in CI.Changes
lintscript towinamp-eqf/package.json:eslint src --ext ts,jswinamp-eqf#linttask toturbo.jsonso it runs alongside other packages during CITesting
pnpm run lintpasses with no errorsprettier/prettierrule